Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test #6122

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

test #6122

wants to merge 2 commits into from

Conversation

OleksandrFEdev
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code is almost there, but there are a few critical issues that need to be addressed before we can approve it. The most important ones are:

  1. Font Embedding: Ensure that the Google Fonts link includes only the required weight and style as specified in the task.
  2. CSS Transition: The transition property is missing a specific property to transition. Please define it correctly, such as transition: color 0.5s ease;.
  3. HTML Formatting: Update the alt attribute for the logo image to provide a more descriptive text.

These changes are necessary to fully meet the task requirements. Once you've made these adjustments, your code will be in great shape! Keep up the good work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

src/style.css Outdated
font-weight: 500;
font-size: 12px;
color: #000;
transition: 0.5 ease;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The transition property is missing a property to transition. It should be defined as transition: property duration timing-function; for it to work correctly. Consider specifying a property, such as color, to transition.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your submission! 🎉 While your code is mostly well-structured, there are a few critical issues that need attention to fully meet the task requirements:

  1. Font Embedding: The Google Fonts link currently includes a range of weights and styles (100..900). Make sure to select only the roman style, medium (500) weight, and normal width for embedding to optimize loading times and meet the task's constraints.

  2. CSS Transition: The :hover effect on .navigation__link changes the color, but there is no transition property defined. To ensure a smooth effect, consider adding transition: color 0.5s ease; to this selector.

  3. HTML Formatting: The alt attribute for the logo image is set to "logo". For better accessibility, provide a more descriptive text, such as "Moyo Company Logo".

These improvements are crucial for enhancing the functionality and accessibility of your code. Although the decision is to APPROVE your pull request to help you move forward with your learning, please address these issues in future projects to avoid similar problems. Keep up the good work and continue to learn from your experiences! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +28 to +31
<link
href="https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,100..900;1,100..900&display=swap"
rel="stylesheet"
/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Google Fonts link includes a range of weights and styles (from 100 to 900) for both italic and normal styles. Ensure that the link includes only the required weight and style as specified in the task requirements. This will help optimize loading times and meet the task's constraints.

>
<img
src="images/logo.png"
alt="logo"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alt attribute for the logo image is currently set to 'logo'. Consider providing a more descriptive text, such as 'Moyo Company Logo', to improve accessibility and meet the task requirements.

Comment on lines +55 to +57
.navigation__link:hover {
color: var(--text-color);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The :hover effect on .navigation__link changes the color, but there is no transition property defined. According to the task checklist, you need to include a transition for the color change to ensure a smooth effect. Consider adding transition: color 0.5s ease; to this selector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants