Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #3849

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add task solution #3849

wants to merge 4 commits into from

Conversation

ilyaivasyk
Copy link

Esceype
Esceype suggested changes Dec 6, 2023
View reviewed changes
Copy link

@Esceype Esceype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!
Read the following comments and please double check the values in design

src/style.css Outdated
font-size: 14px;
}

.form__form-big__input:focus, .form__form-sm__input:focus {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create one general form input class you don`t need to create two classes

src/style.css Outdated
Comment on lines 83 to 84
top: 50%;
left: 25px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is wrong values please double check the design

src/style.css Outdated
}

.form__form-big__input {
padding: 23px 60px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This padding cut the image as you can see and that's one of the problems keeping your tests from being successful.

@ilyaivasyk
Copy link
Author

Меніне дали відповідь на питання в чаті(

@ilyaivasyk ilyaivasyk requested a review from Esceype December 9, 2023 19:50
l4st1m0za
l4st1m0za approved these changes Dec 10, 2023
View reviewed changes
Copy link

@l4st1m0za l4st1m0za left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I can see that you have fixed the issue, but for the next tasks, please, don't forget to ran the tests so that they will be based on your latest changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l4st1m0za l4st1m0za l4st1m0za approved these changes

@Esceype Esceype Awaiting requested review from Esceype

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilyaivasyk @Esceype @l4st1m0za