-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #3852
base: master
Are you sure you want to change the base?
Develop #3852
Changes from 18 commits
06860de
08f3872
e9e7e5e
609e181
b383df0
9374efd
0e3c60f
d989bd1
103099c
c1b9bc5
2b674d9
73502f1
883c7a2
6fd5add
d756c6b
190cf51
bc68204
2c48059
b3ab305
dd214c0
5fffb5c
28c3b44
0afd62c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,108 @@ | ||
/* add styles here */ | ||
* { | ||
box-sizing: border-box; | ||
} | ||
|
||
:root { | ||
--color: #3d4e61; | ||
--border-color: #e1e7ed; | ||
--main-bs-color: rgba(61, 78, 97, 0.1); | ||
} | ||
|
||
html { | ||
padding: 0; | ||
font-family: Avenir, sans-serif; | ||
} | ||
|
||
@font-face { | ||
font-family: Avenir; | ||
src: url("./fonts/Avenir-Book.ttf"); | ||
} | ||
|
||
@font-face { | ||
font-family: AvenirHeavy; | ||
src: url("./fonts/Avenir-Heavy.ttf"); | ||
} | ||
|
||
/* #region larger search bar & identical search bars code */ | ||
|
||
.search-bar { | ||
display: flex; | ||
align-items: center; | ||
|
||
background-color: #FFF; | ||
border: 1px solid var(--border-color); | ||
border-radius: 4px; | ||
} | ||
|
||
.search-bar--larger { | ||
margin: 20px 0; | ||
height: 70px; | ||
} | ||
|
||
.icon { | ||
background-image: url(./images/Search.svg); | ||
background-repeat: no-repeat; | ||
background-position: center; | ||
background-size: contain; | ||
} | ||
|
||
.icon--search { | ||
width: 19px; | ||
height: 19px; | ||
margin: 0 16px 0 25px; | ||
} | ||
|
||
.input { | ||
font-family: inherit; | ||
font-weight: 300; | ||
width: 85%; | ||
height: 100%; | ||
outline: none; | ||
border: 0; | ||
background: none; | ||
color: var(--color); | ||
} | ||
|
||
.input--larger { | ||
font-size: 16px; | ||
} | ||
|
||
.input::placeholder { | ||
color: var(--color); | ||
} | ||
|
||
/* #endregion */ | ||
|
||
/* #region smaller search bar */ | ||
|
||
.search-bar--mini { | ||
min-height: 42px; | ||
} | ||
|
||
.icon--search-mini { | ||
width: 11px; | ||
height: 11px; | ||
margin: 0 7px 0 13px; | ||
} | ||
|
||
.input--mini { | ||
font-size: 14px; | ||
} | ||
|
||
/* #endregion */ | ||
|
||
.search-bar:hover { | ||
border-radius: 4px; | ||
border: 1px solid #E1E7ED; | ||
box-shadow: 0 3px 8px 0 rgba(61, 78, 97, 0.20); | ||
} | ||
|
||
.search-bar:focus-within { | ||
background: linear-gradient(180deg, #FFF 0%, #F6F6F7 100%); | ||
} | ||
|
||
.input:focus { | ||
background: none; | ||
font-weight: 900; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. tru do not set font-weight for focus. looks like such font styles should be for input, and for placeholder set font styles that in design. it can help fix tests. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the bugs are fixed and the test is now working |
||
text-shadow: 0 4px 4px 0 rgba(0, 0, 0, 0.25); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is redundant to make search-bar--larger modifier for big form. set all styles in search-bar and change necessary in search-bar-mini modifier for small form.
same for other elements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but in this case the CSS file will become larger because many identical lines will appear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mant thx for comments