Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #3860

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #3860

wants to merge 2 commits into from

Conversation

kovaltar
Copy link

@kovaltar kovaltar commented Dec 8, 2023

  • DEMO LINK

  • TEST REPORT LINK

  • Icon implemented using background-image CSS property

  • Inputs are written inside of 'form' tag with correctly passed attributes

  • All Typical Mistakes from BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

loralevitska
loralevitska suggested changes Dec 9, 2023
View reviewed changes
Copy link

@loralevitska loralevitska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done) Let's improve

  • try to pass the last test, check font-weight for small search-bar
    image

@kovaltar
Copy link
Author

kovaltar commented Dec 9, 2023

Almost done) Let's improve

  • try to pass the last test, check font-weight for small search-bar
    image

I have no idea what to do with last test. Font styles are the same as in figma but last test didin't pass:(

@kovaltar kovaltar requested a review from loralevitska December 9, 2023 17:43
l4st1m0za
l4st1m0za approved these changes Dec 10, 2023
View reviewed changes
Copy link

@l4st1m0za l4st1m0za left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! As for me you small input looks exactly like it shuold!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l4st1m0za l4st1m0za l4st1m0za approved these changes

@loralevitska loralevitska Awaiting requested review from loralevitska

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kovaltar @l4st1m0za @loralevitska