Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

done search-bar #3864

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

done search-bar #3864

wants to merge 1 commit into from

Conversation

IvanVaniuk
Copy link

l4st1m0za
l4st1m0za approved these changes Dec 10, 2023
View reviewed changes
Copy link

@l4st1m0za l4st1m0za left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Consider the comments for the next tasks!

src/index.html
method="POST"
class="box"
>
<div href="#" class="box__icon"></div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'div' element does not support the 'href' attribute. Consider using an 'a' tag instead if you want to create a link.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

я делал через а, решил потом подумал, сделать через див, просто тег переименовал, за href вообще забыл )
спасибо за коменты, учту )

src/index.html
method="POST"
class="box"
>
<div href="#" class="box__link"></div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'div' element does not support the 'href' attribute. Consider using an 'a' tag instead if you want to create a link.

src/style.css
Comment on lines +19 to +21
margin-top: 20px;
margin-left: 8px;
margin-right: 8px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
margin-top: 20px;
margin-left: 8px;
margin-right: 8px;
margin: 20px 8px 0 8px;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l4st1m0za l4st1m0za l4st1m0za approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IvanVaniuk @l4st1m0za