Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 2 inputs #3865

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add 2 inputs #3865

wants to merge 4 commits into from

Conversation

yaGodya
Copy link

@yaGodya yaGodya commented Dec 10, 2023

  • DEMO LINK

  • TEST REPORT LINK

  • Icon implemented using background-image CSS property

  • Inputs are written inside of 'form' tag with correctly passed attributes

  • All Typical Mistakes from BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

Copy link

@polosanya polosanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Let's improve your code a bit)

  1. Placeholder shouldn't change on focus
    image

src/index.html Outdated
Comment on lines 16 to 19
<form action="#"
method="post"
data-qa="big"
class="form">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the formatting according to the checklist
image

src/index.html Outdated
class="big-img">
<input type="text"
class="input big-input"
name="big-serch-bar"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name="big-serch-bar"
name="big-search-bar"

src/index.html Outdated
</body>
</html>

</html>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…r font-weight i focus and correct formating code
@yaGodya yaGodya requested a review from polosanya January 30, 2024 15:40
Copy link

@StasSokolov1 StasSokolov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done, check the comments from @polosanya, focus still exists and formatting has not been fixed
Снимок экрана 2024-01-31 в 11 03 37

@yaGodya yaGodya requested a review from StasSokolov1 January 31, 2024 09:31
Copy link

@StasSokolov1 StasSokolov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a masterpiece, I'm approving it🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants