add task solution #3866
add task solution #3866
Conversation
src/style.css
Outdated
| color: var(--main-text-colot); | ||
| } | ||
|
|
||
| input { |
There was a problem hiding this comment.
I need to set color: var(--main-text-colot) in search-form__input ?
There was a problem hiding this comment.
do not style by tags. move all styles for input to .search-form__input selector.
box-sizing better to set in * selector
src/style.css
Outdated
| } | ||
|
|
||
| html { | ||
| font-family: Avenir, sans-serif; |
src/index.html
Outdated
| data-qa="big" | ||
| > | ||
| <label class="search-form__label"> | ||
| <span class="search-form__image search-form__image--big"></span> |
There was a problem hiding this comment.
Just set all styles in this selectors to search-form__input, you don`t need this additional span here and in the small form
src/index.html
Outdated
| <span class="search-form__image search-form__image--big"></span> | ||
| <input | ||
| type="text" | ||
| class="search-form__input search-form__input--big" |
There was a problem hiding this comment.
| class="search-form__input search-form__input--big" | |
| class="search-form__input" |
you don't need --big modifier.
set all styles in .search-form__input selector and change necessary for --small modifier.
same for other elements
src/style.css
Outdated
| color: var(--main-text-colot); | ||
| } | ||
|
|
||
| input { |
There was a problem hiding this comment.
do not style by tags. move all styles for input to .search-form__input selector.
box-sizing better to set in * selector
src/style.css
Outdated
| padding-left: 62px; | ||
| font-size: 16px; |
There was a problem hiding this comment.
move this styles in .search-form__input selector
|
|
||
| .search-form__input { | ||
| outline: none; | ||
| box-sizing: border-box; |
There was a problem hiding this comment.
box-sizing better to set for * selector.
* {
box-sizing: border-box
}
DEMO LINK
TEST REPORT LINK
Icon implemented using background-image CSS property
Inputs are written inside of 'form' tag with correctly passed attributes
All
Typical MistakesfromBEMlesson theory are checked.Code follows all the Code Style Rules ❗️