all done #3881
Open
all done #3881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyr-soltys97
suggested changes
Dec 15, 2023
src/style.css
Outdated
|
|
||
| .search-form__input { | ||
| border-radius: 4px; | ||
| border: 1px solid #E1E7ED; |
There was a problem hiding this comment.
Create a variable for repeating colors
SanyaBratashchuk
suggested changes
Dec 17, 2023
src/style.css
Outdated
|
|
||
| .search-form__input::placeholder { | ||
| color: #3D4E61; | ||
| font-family: Avenir , sans-serif; |
There was a problem hiding this comment.
apply font-family for html tag selector and let inputs inherit it
Suggested change
| font-family: Avenir , sans-serif; | |
| font-family: inherit; |
src/style.css
Outdated
|
|
||
| .search-form__input_big { | ||
| padding-left: 62px; | ||
| box-sizing: border-box; |
There was a problem hiding this comment.
apply box-sizing to all elements via * selector
|
i don't add font-family for html tag selector and let inputs inherit it when i did this Big_search_bar_data-qa_big_720px.png failed only this test i don't know why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DEMO LINK] https://vadymbryvka.github.io/layout_search-bar-airbnb/
[TEST REPORT LINK] https://vadymbryvka.github.io/layout_search-bar-airbnb/report/html_report/
By the way you see these three commits they failed because when i launched npm test in terminal all test be successful. But in github they show me eror. (I can give more information if you need)