Search bar add task solution #4774
Conversation
aholubko
commented
Feb 15, 2025
aholubko
commented
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Great job on your submission! 🎉 While there are a few minor issues, such as the spacing between search bars and placeholder text differentiation, these do not significantly impact the functionality of your code. You've done well in structuring your HTML and CSS. Keep up the good work, and consider the feedback for future improvements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| placeholder="Try “Los Angeles“" | ||
| /> | ||
| </form> | ||
|
|
||
| <input | ||
| type="text" | ||
| data-qa="hover" | ||
| placeholder="Try “Los Angeles“" | ||
| /> | ||
| <form | ||
| class="search__form search__form--small" | ||
| data-qa="small" | ||
| > | ||
| <input | ||
| class="search__input search__input--small" | ||
| type="text" | ||
| data-qa="hover" | ||
| placeholder="Try “Los Angeles“" |
There was a problem hiding this comment.
The placeholder text for both input fields is the same: 'Try “Los Angeles“'. Consider differentiating the placeholder text for each form to provide a clearer distinction between the 'big' and 'small' search forms, enhancing user experience.
| src: | ||
| url(./fonts/Avenir-Book.ttf) format('truetype'), | ||
| url(./fonts/Avenir-Heavy.ttf) format('truetype'); | ||
| font-weight: 300; |
There was a problem hiding this comment.
The font-weight is set to 300, which typically corresponds to a 'light' font weight. However, the src includes 'Avenir-Heavy.ttf', which suggests a heavier font weight. Ensure that the font-weight matches the actual font file being used. If 'Avenir-Heavy.ttf' is intended to be used, consider adjusting the font-weight to a heavier value, such as 700 or 800.
