Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1903

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #1903

wants to merge 1 commit into from

Conversation

ADRIREG
Copy link

@ADRIREG ADRIREG commented Nov 10, 2024

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Great job on categorizing the variables into 'mutable' and 'immutable' types! 🎉 Your solution meets the task requirements perfectly. While your approach using type() works, consider using isinstance() for type checking in the future. It's more Pythonic and offers better readability and flexibility. Keep up the excellent work and continue refining your skills! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +28 to +29
if (type(each_variable) == list or type(each_variable) == dict
or type(each_variable) == set):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using type() for type checking is not recommended. Consider using isinstance() instead. For example, isinstance(each_variable, (list, dict, set)) would be a more Pythonic way to check if the variable is mutable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants