Skip to content

Fix repeated word typos #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025
Merged

Fix repeated word typos #191

merged 2 commits into from
May 16, 2025

Conversation

xofbd
Copy link
Contributor

@xofbd xofbd commented Aug 13, 2024

A few typos I found when reading the documention.

@matejak
Copy link
Owner

matejak commented Apr 27, 2025

This is tricky, because in a way, the "default default" is correct wording. What it wants to say is that e.g. ARG_OPTIONAL_SINGLE accepts a parameter default that is optional, and the default value of that parameter is an empty string. So, the empty string is a default value of the default parameter, i.e. default default.
What do you think?

@matejak
Copy link
Owner

matejak commented May 12, 2025

@kstrafe could you please provide your input? Is this PR fixing a bug, is it a misunderstanding, or can the phrasing be improved by other means?

@kstrafe
Copy link
Contributor

kstrafe commented May 12, 2025

I think the phrasing can be improved upon. Maybe something like Unless specified, the default is X.

@matejak
Copy link
Owner

matejak commented May 14, 2025

Thanks @xofbd for the suggestion though.

@matejak matejak merged commit 415be68 into matejak:master May 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants