Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SideSheet] Prevent NullPointerException when viewRef was nullified and only then accessed by runAfterLayout lambda #4615

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eugenegff
Copy link

@eugenegff eugenegff commented Feb 20, 2025

Prevent NullPointerException when viewRef was nullified as part of SideSheetBehavior.onDetachedFromLayoutParams() and only then accessed by runAfterLayout lambda. Similar nearby checks outside of lambda are not enough, as all of them are executed immediately, and access in lambda is done later, after layout.

Issue is rare enough, but occurs periodically in the wild

Screenshot 2025-02-20 at 15 26 40

…s part of SideSheetBehavior.onDetachedFromLayoutParams() and only then accessed by runAfterLayout lambda
Copy link

google-cla bot commented Feb 20, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@eugenegff
Copy link
Author

signed cla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant