feat: add react-native and metro icons #2171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
luas10c
changed the title
PKief
reviewed
Dec 23, 2023
icons/react-native.svg
Outdated
There was a problem hiding this comment.
Looks very similar to the already existing react logo, why don't we reuse it?
https://github.com/PKief/vscode-material-icon-theme/blob/main/icons/react.svg
PKief
reviewed
Dec 23, 2023
icons/metro.svg
Outdated
There was a problem hiding this comment.
Add some spacing around the icon pls:
https://github.com/PKief/vscode-material-icon-theme/blob/main/CONTRIBUTING.md#icon-spacing
PKief
reviewed
Dec 23, 2023
| 'metro.config.js', | ||
| 'metro.config.mjs', | ||
| 'metro.config.cjs', | ||
| 'metro.config.ts' |
There was a problem hiding this comment.
File is not formatted via prettier
PKief
force-pushed
the
main
branch
2 times, most recently
from
eeb4f0e to
b2e0fe4
Compare
PKief
force-pushed
the
main
branch
2 times, most recently
from
2ff604a to
b1ad1d2
Compare
PKief
force-pushed
the
main
branch
2 times, most recently
from
ed9ed26 to
55e5e9c
Compare
PKief
force-pushed
the
main
branch
2 times, most recently
from
7918c28 to
7cb05b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw the need to add icons to the facebook/metro config and react-native cli configuration file
Features