Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add umi icon #2203

Merged
merged 5 commits into from
Nov 11, 2024
Merged

feat: add umi icon #2203

merged 5 commits into from
Nov 11, 2024

Conversation

fz6m
Copy link
Contributor

@fz6m fz6m commented Jan 27, 2024

Umi is a React framework.

This comment was marked as outdated.

@PKief
Copy link
Member

PKief commented Jan 28, 2024

Please have a look at the failed pipeline. Might be because you're using the wrong colors for the icon.

This comment was marked as outdated.

@PKief
Copy link
Member

PKief commented Nov 9, 2024

I'd like to see a more "material" version of this icon to make it into this extension. I just experimenced with it and came up with this version:

Preview in VS Code
image


That's the code of the updated SVG:

<svg width="16" height="16" version="1.1" viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg">
 <g>
  <path d="m1 8a7 7 0 0 0 4 6.3164v0.68359h3 3v-0.68359a7 7 0 0 0 4-6.3164h-14z" fill="#455a64"/>
  <path d="m8 3a5 5 0 0 0-5 5h10a5 5 0 0 0-5-5z" fill="#f5f5f5"/>
  <path d="m2.0918 9a6 6 0 0 0 5.9082 5 6 6 0 0 0 5.9082-5h-11.816z" fill="#2196f3"/>
 </g>
 <g fill="#455a64">
  <g stroke-width="0">
   <circle cx="5.5" cy="6.5" r=".5"/>
   <circle cx="10.5" cy="6.5" r=".5"/>
   <circle cx="6.5" cy="5.5" r=".5"/>
  </g>
  <path d="m8 2a6 6 0 0 0-6 6h1a5 5 0 0 1 5-5 5 5 0 0 1 5 5h1a6 6 0 0 0-6-6z"/>
 </g>
</svg>

@github-actions github-actions bot added the icons PR with new icons label Nov 10, 2024
Copy link

github-actions bot commented Nov 10, 2024

Preview

Thank you for creating a pull request. This preview shows you how your icon will look on the different themes:

Generated preview

Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@fz6m
Copy link
Contributor Author

fz6m commented Nov 10, 2024

Thank you very much for your work ! I have updated the icon

src/core/icons/fileIcons.ts Outdated Show resolved Hide resolved
Co-authored-by: Okinea Dev <[email protected]>
Signed-off-by: Sakina <[email protected]>
@okineadev okineadev changed the title feat: add umi icon feat: add umi icon Nov 11, 2024
@okineadev okineadev merged commit 8cf191a into material-extensions:main Nov 11, 2024
5 checks passed
Copy link

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the Marketplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons PR with new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants