feat: add rspack and rsbuild icons #2240
Conversation
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
PreviewThank you for creating a pull request. This preview shows you how your changes will look on the different themes: You can find more information how to contribute in the contribution guidelines. |
|
Should we add the rspress icon ? |
PKief
force-pushed
the
main
branch
2 times, most recently
from
eeb4f0e
to
b2e0fe4
Compare
PKief
force-pushed
the
main
branch
2 times, most recently
from
2ff604a
to
b1ad1d2
Compare
|
@fz6m We can preparing the Rspress SVG logo, see rspack-contrib/rstack-design-resources#11 |
|
@PKief May I know what blocked this PR? Thanks |
PreviewThank you for creating a pull request. This preview shows you how your icons will look on the different themes: Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link. You can find more information on how to contribute in the contribution guidelines. |
The icon has many details. Usually I prefer having more simplified icons. In addition, the colors are not fitting the material color palette. This ensures that all icons are fitting together and have a nice contrast. |
|
Thank you for your feedback, we will try to improve it |
Hmm, got it, but this is how Rstack logo designed. IIUC, it's better to design a set of more concise icons to fit vscode-material-icon-theme? |
Yeah, I'd recommend that. If you take a look at the preview, it's not even possible to recognize all of the details of that icon: 
The goal of this icon extension is not just using the exact logos but to provide a nice set of icons which are highly recognisable and are in Material Design Colors. Sometimes it's not possible to have an icon for something if the logo is too complex. Then a solution could be to abstract the original logo and make it more simple. |
|
We will try to provide a more concise design. |
PKief
force-pushed
the
main
branch
2 times, most recently
from
ed9ed26
to
55e5e9c
Compare
resolve #2174.