Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new icons for directive folder #2690

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

javierhidalgodev
Copy link
Contributor

Description

Added icons for directive folder.

Contribution Guidelines

@github-actions github-actions bot added the icons PR with new icons label Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

Preview

Thank you for creating a pull request. This preview shows you how your icons will look on the different themes:

Generated preview

Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@okineadev

This comment was marked as off-topic.

Copy link
Member

@okineadev okineadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The folder icon does not match the new style, find an icon with smooth corners and use it as a base

src/core/icons/folderIcons.ts Outdated Show resolved Hide resolved
@PKief
Copy link
Member

PKief commented Nov 9, 2024

@okineadev is right, the folder icon in the background is not the same one as we're using for all the other folder icons.

You can compare the folder icons here:

Correct one:
https://pixp.lucode.ar/material-extensions/vscode-material-icon-theme/pull/2578

Your one:
https://pixp.pages.dev/material-extensions/vscode-material-icon-theme/pull/2690

Take a look at the shape of the folder icons. It looks different. Try to make it look similar as in the other folder icons.

For any further questions take a look into the Contribution Guidelines and paste further questions here.

@PKief
Copy link
Member

PKief commented Nov 11, 2024

On a very small perspective - as we have it in the file explorer of VS Code - it might look more like a cross than the arrows now:

image

What do you think?

@lucas-labs
Copy link
Member

On a very small perspective - as we have it in the file explorer of VS Code - it might look more like a cross than the arrows now ...

I liked the first version of the motive

@javierhidalgodev
Copy link
Contributor Author

It’s right, I prefer the first icon version too.

@PKief PKief requested a review from okineadev November 12, 2024 19:17
@okineadev okineadev merged commit 28f2265 into material-extensions:main Nov 12, 2024
5 checks passed
Copy link

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the Marketplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons PR with new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants