-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Not) Use setup-uv
in CI tests workflow
#4063
Conversation
bebbfec
to
3fd0d0c
Compare
@janosh Turns out there isn't much speed advantage for |
setup-uv
in CI tests workflowsetup-uv
in CI tests workflow
good to know. i wasn't expecting it to be faster on a cold cache though. mainly hoping |
Tests on second runs (
|
1a36fe5
to
0db8f72
Compare
thanks so much for your benchmarking! ❤️ that's super useful for the decision at hand and later reference. i agree seems there's not much point in adopting merging now. thanks for cleaning up the needless build-time deps install |
No problem! That's what I was hoping too. Looks like |
Summary
setup-uv
in CI tests workflow, to close Useastral-sh/setup-uv
in CI #4044Performance benchmark
The following word "native" refers to package installed by native github action setups:
setup-Python/micromamba/uv
NOTE:
setup-uv
installer might provide caching function, so the run time might be slower for the first runDependency installation time
Time (in seconds) is reported on the
Install pymatgen and dependencies
stage for "split 1", excluding conda and optional Ubuntu dependenciesConclusion: not much difference between
setup-uv
andpip install uv
, and the M1 MacOS runner is just another level.Pytest running time
Time (in seconds) is reported for "split 1"
Conclusion: Actual test running time is largely not influenced (as expected).
Link to above workflow runs