-
Notifications
You must be signed in to change notification settings - Fork 854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
return bool
instead of np.bool_
#4074
base: master
Are you sure you want to change the base?
Conversation
Beautiful! I believe I have seen issues related to this at some point. I just did a global search (re pattern pymatgen/src/pymatgen/analysis/chemenv/utils/coordination_geometry_utils.py Lines 716 to 727 in ea7c339
pymatgen/src/pymatgen/core/surface.py Lines 308 to 321 in ea7c339
The following might return pymatgen/src/pymatgen/analysis/interfaces/zsl.py Lines 317 to 330 in ea7c339
|
I did some messy
The |
Summary
The return signature of this function is currently
np.bool_
which can cause serialization problems with older atomate1 workflows.Changed to
bool
instead.