Skip to content

Add methods for recomputing a ReactionSet at a new temperature#298

Closed
mcgalcode wants to merge 4 commits into
materialsproject:mainfrom
mcgalcode:main
Closed

Add methods for recomputing a ReactionSet at a new temperature#298
mcgalcode wants to merge 4 commits into
materialsproject:mainfrom
mcgalcode:main

Conversation

@mcgalcode

Copy link
Copy Markdown
Collaborator

Adds a new method for creating a new reaction set from an existing reaction set by re-computing the reaction energies at a new temperature.

In doing this, we also add an optional cache parameter to the Reaction object get_new_temperature method which allows for the passing of precomputed entry formation energies at specific temperatures. This allows us to avoid recomputing entry energies at the new temperature if those entries appear in multiple reactions.

This is used in ReactCA for several years now, so this PR is helpful hygiene.

@mcgalcode mcgalcode requested review from mattmcdermott and removed request for mattmcdermott June 8, 2026 17:08
@mcgalcode

Copy link
Copy Markdown
Collaborator Author

This test failed because no API key was found... That's not really related to this change at all so I imagine that main doesn't pass these tests either. Same goes for linting, which highlights many errors outside of the files affected by this PR.

@mcgalcode

Copy link
Copy Markdown
Collaborator Author

Closing in favor of a PR from the main repo (to allow CI secrets access)

@mcgalcode mcgalcode closed this Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant