Add methods for recomputing a ReactionSet at a new temperature#300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new method for creating a new reaction set from an existing reaction set by re-computing the reaction energies at a new temperature.
In doing this, we also add an optional cache parameter to the Reaction object get_new_temperature method which allows for the passing of precomputed entry formation energies at specific temperatures. This allows us to avoid recomputing entry energies at the new temperature if those entries appear in multiple reactions.
This is used in ReactCA for several years now, so this PR is helpful hygiene.