-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop schema contents when deleting #4251
base: develop
Are you sure you want to change the base?
Conversation
@pavish I made very tiny FE changes, so I assigned you to look at those. |
.gitignore
Outdated
@@ -186,6 +186,7 @@ node_modules/ | |||
|
|||
# Client Build files | |||
mathesar/static/mathesar/ | |||
static/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will ignore any new files within /mathesar/static
.
We have a number of icons and images here which are used in the product within /mathesar/static/non-code
. We should be ignoring the exact path we need to ignore and not have a general static/
matcher here.
@@ -102,7 +102,7 @@ export class Schema { | |||
return api.schemas | |||
.delete({ | |||
database_id: this.database.id, | |||
schema_oid: this.oid, | |||
schema_oids: [this.oid], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
@pavish This should be ready for re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #4240
Modifies the
schemas.delete
RPC function to drop all objects within passed schemas, and then the schemas themselves, withoutCASCADE
.Technical details
CASCADE
, but lets users delete schemas that still contain objectsChecklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin