Skip to content

Conversation

@anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented Oct 7, 2025

After adding validation to /keys/upload on Synapse, uses of this function with mostly-empty bodies were no longer valid.

This change adds fake test data to them where necessary.


This is paired with element-hq/synapse#17097, which was accidentally merged before these tests were.

This change should be backported to the release-v1.138 and release-v1.139 branches, as the linked PR was backported to those Synapse releases.

After adding validation to `/keys/upload` on Synapse, uses of this function with mostly-empty bodies were no longer valid.

This change adds fake test data to them where necessary.
@anoadragon453 anoadragon453 requested a review from a team as a code owner October 7, 2025 14:07
@anoadragon453 anoadragon453 merged commit d2ecc51 into develop Oct 7, 2025
7 checks passed
@anoadragon453 anoadragon453 deleted the s7evink/validate-upload-keys-dict branch October 7, 2025 14:47
@anoadragon453
Copy link
Member Author

This commit has been backported to release-v1.138 and release-v1.139 branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants