Skip to content

fix: add roll-out log to track config change history #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aylei merged 1 commit into from
Dec 25, 2024
Merged

fix: add roll-out log to track config change history #574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/controllers/common/configmap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import (
"github.com/matrixorigin/matrixone-operator/api/core/v1alpha1"
corev1 "k8s.io/api/core/v1"
apierrors "k8s.io/apimachinery/pkg/api/errors"
"k8s.io/klog"
"sigs.k8s.io/controller-runtime/pkg/client"
)

Expand Down Expand Up @@ -93,6 +94,10 @@ func ensureConfigMap(kubeCli recon.KubeClient, desired *corev1.ConfigMap) (strin
if withDigest(key, v) && configInUse(key, podList.Items) {
// append item that is still in use
c.Data[key] = v
} else {
// log roll-out event to track configmap changes
klog.Infof("config key %s is not in use, will be deleted. configmap %s/%s, value: %s",
key, c.Namespace, c.Name, v)
}
}
err = kubeCli.Update(c)
Expand Down
Loading