Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readFully requestLimit checks … #277

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

simonwibberley
Copy link

readFully requestLimit checks requestLimit instead of depthlimit, so can be enabled separately.

@codecov
Copy link

codecov bot commented Sep 5, 2018

Codecov Report

Merging #277 into master will decrease coverage by 78.7%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #277       +/-   ##
============================================
- Coverage     79.15%   0.44%   -78.71%     
+ Complexity      707       7      -700     
============================================
  Files           131     131               
  Lines          2461    2461               
  Branches        318     318               
============================================
- Hits           1948      11     -1937     
- Misses          329    2449     +2120     
+ Partials        184       1      -183
Impacted Files Coverage Δ Complexity Δ
...n/kotlin/net/dean/jraw/tree/AbstractCommentNode.kt 0% <0%> (-69.57%) 0 <0> (-36)
...rc/main/kotlin/net/dean/jraw/models/GeneralSort.kt 0% <0%> (-100%) 0% <0%> (-1%)
...in/net/dean/jraw/references/ModerationReference.kt 0% <0%> (-100%) 0% <0%> (-2%)
...et/dean/jraw/models/internal/SubredditElement.java 0% <0%> (-100%) 0% <0%> (-3%)
...n/kotlin/net/dean/jraw/references/WikiReference.kt 0% <0%> (-100%) 0% <0%> (-8%)
...va/net/dean/jraw/models/SubredditSearchResult.java 0% <0%> (-100%) 0% <0%> (-2%)
...c/main/java/net/dean/jraw/models/AccountQuery.java 0% <0%> (-100%) 0% <0%> (-3%)
...rc/main/kotlin/net/dean/jraw/http/BasicAuthData.kt 0% <0%> (-100%) 0% <0%> (-3%)
...in/java/net/dean/jraw/models/KarmaBySubreddit.java 0% <0%> (-100%) 0% <0%> (-2%)
...c/main/kotlin/net/dean/jraw/http/NoopHttpLogger.kt 0% <0%> (-100%) 0% <0%> (-3%)
... and 115 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d466dfe...ff8dde5. Read the comment docs.

@Emilius123
Copy link

looks gay 2 me, m8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants