Lower contract creation using the new operator to $zk_create intrinsics

[abinavpp]

No description provided.

[abinavpp]

This depends on the zkevm extension infrastructure introduced in #1 . Either we need to add #1 to all the other release branches, or we should make a separate PR containing this change and all its dependencies in 1 commit that can be applied to all the other release branches. This is currently based on #2 only due to the newly added test in the ZKEVM directory

[zksync-admin-bot2]

Benchmark results:

╔═╡ Size (-%) ╞═════════════════════╡ All ╞═╗
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                                 NaN ║
╠═╡ Cycles (-%) ╞═══════════════════╡ All ╞═╣
║ Mean                                0.000 ║
║ Best                                0.000 ║
║ Worst                               0.000 ║
║ Total                                 NaN ║
╚═══════════════════════════════════════════╝

[abinavpp]

@hedgar2017 When I check one of the CI failure, say: cargo run --release --bin compiler-tester -- -vD --mode='Y-M1B3 0.8.17' --path=tests/solidity/ethereum/salted_create/salted_create.sol. I'm getting the following error:

LLVM IR generator definition pass error: 141:40 Undeclared function `$zk_create2`

The diff in tests_solidity_ethereum_salted_create_salted_create.sol.A.yul only shows some instance of create2 replaced with $zk_create2, I didn't see any other changes

[hedgar2017]

@hedgar2017 When I check one of the CI failure, say: cargo run --release --bin compiler-tester -- -vD --mode='Y-M1B3 0.8.17' --path=tests/solidity/ethereum/salted_create/salted_create.sol. I'm getting the following error:

LLVM IR generator definition pass error: 141:40 Undeclared function `$zk_create2`

The diff in tests_solidity_ethereum_salted_create_salted_create.sol.A.yul only shows some instance of create2 replaced with $zk_create2, I didn't see any other changes

Ah, well, I haven't added it yet.
Easy fix, will do today.

[abinavpp]

@hedgar2017 When I check one of the CI failure, say: cargo run --release --bin compiler-tester -- -vD --mode='Y-M1B3 0.8.17' --path=tests/solidity/ethereum/salted_create/salted_create.sol. I'm getting the following error:

LLVM IR generator definition pass error: 141:40 Undeclared function `$zk_create2`

The diff in tests_solidity_ethereum_salted_create_salted_create.sol.A.yul only shows some instance of create2 replaced with $zk_create2, I didn't see any other changes

Similarly, --mode=E+M2B1 is failing with the error " Failed to get main contract: solc-bin//solc-0.8.17 subprocess output parsing error: data did not match any variant of untagged enum Data at line 1 column 18563"

For some reason, I'm not able to see any $zk_create* operation in any file in the debug directory, but I do see it in the verbose output of compiler-tester, like:

                 {                                                                                                                                                                            
                    "begin": 133,                                                                                                                                                              
                    "end": 155,                                                                                                                                                                
                    "name": "$ZK_CREATE2",                                                                                                                                                     
                    "source": 0                                                                                                                                                                
                  },

[hedgar2017]

@hedgar2017 When I check one of the CI failure, say: cargo run --release --bin compiler-tester -- -vD --mode='Y-M1B3 0.8.17' --path=tests/solidity/ethereum/salted_create/salted_create.sol. I'm getting the following error:

LLVM IR generator definition pass error: 141:40 Undeclared function $zk_create2

The diff in tests_solidity_ethereum_salted_create_salted_create.sol.A.yul only shows some instance of create2 replaced with $zk_create2, I didn't see any other changes

Similarly, --mode=E+M2B1 is failing with the error " Failed to get main contract: solc-bin//solc-0.8.17 subprocess output parsing error: data did not match any variant of untagged enum Data at line 1 column 18563"

For some reason, I'm not able to see any $zk_create* operation in any file in the debug directory, but I do see it in the verbose output of compiler-tester, like:

                 {                                                                                                                                                                            

                    "begin": 133,                                                                                                                                                              

                    "end": 155,                                                                                                                                                                

                    "name": "$ZK_CREATE2",                                                                                                                                                     

                    "source": 0                                                                                                                                                                

                  },

Yes, the same reason.

[abinavpp]

@hedgar2017, can you check the generated code in yul and evmla and let me know if further changes are required?

[hedgar2017]

@hedgar2017, can you check the generated code in yul and evmla and let me know if further changes are required?

Yes, will test soon.

To change the Linear status.