Remove direct sha3 dependency #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkevm_opcode_defs selects it properly.
joonazan
force-pushed
the
fix-transmute
branch
from
73a757e
to
5f62ad1
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Nice of the day |
rayhan97794
reviewed
Mar 21, 2024
|
Chack it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zkevm_opcode_defs properly pins sha3 it to a specific version. This is important because we rely on the internal representation used in the library, so even minor changes can break our code.
I'm not sure if v1.3.2 is the best branch for this.