Remove references to 'block' function #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for running this down. I don't see a big issue with bumping the minimum required fish version to 3.3. Will leave this up for a bit to see if anyone balks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the call to
block -lfrom the codebase, as it's no longer of use (since some time in 2021) and apparently the function may be removed in the future.cf. fish-shell/fish-shell#10383 (comment)
I'm submitting this just because I happened to stumble on it and thought I might spare lucid a bug in the future - please do reject the PR if you are more concerned about compatibility with old versions of fish than about future-proofing.