Skip to content

switch to PHP attributes for test & data provider markers #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jnahmias wants to merge 1 commit into
base: master
Choose a base branch
from
Open

switch to PHP attributes for test & data provider markers #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/ConverterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

use MatthiasMullie\PathConverter\Converter;
use PHPUnit\Framework\TestCase;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\Attributes\Test;

/**
* Converter test case.
Expand All @@ -12,11 +14,9 @@ class ConverterTest extends TestCase
{
/**
* Test Converter, provided by dataProvider.
*
* @test
*
* @dataProvider dataProvider
*/
#[Test]
#[DataProvider('dataProvider')]
public function convert($relative, $from, $to, $expected)
{
$converter = new Converter($from, $to, '/');
Expand Down
10 changes: 5 additions & 5 deletions tests/NoConverterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,19 @@

use MatthiasMullie\PathConverter\NoConverter;
use PHPUnit\Framework\TestCase;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\Attributes\Test;

/**
* Converter test case.
*/
class NoConverterTest extends TestCase
{
/**
* Test Converter, provided by dataProvider.
*
* @test
*
* @dataProvider dataProvider
* Test NoConverter, provided by dataProvider.
*/
#[Test]
#[DataProvider('dataProvider')]
public function convert($relative, $expected)
{
$converter = new NoConverter();
Expand Down