Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the parser compile for Windows and Linux machines #53

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PolarGoose
Copy link

@PolarGoose PolarGoose commented Nov 8, 2023

Description

I have tried the proposal from @matthijskooijman and managed to make the parser compile and work on Windows and Linux machines. I have only tested it on Windows, but there shouldn't be any problems with Linux.
This can be very beneficial because the parser can be used on Raspberry Pi and other Linux-based embedded boards, for example.

Content of the pull request

  • Replace the usage of Arduino String with std::string
  • Add a unit test project to test the parser

* Replace the usage of Arduino String with std::string
* Add a unit test project to test the parser
@PolarGoose PolarGoose changed the title [Draft] Make the parser compile for Windows and Linux machines Make the parser compile for Windows and Linux machines Nov 8, 2023
@LarsStegman
Copy link

This is great! When this is merged, ESPHome can be updated to use the new version. This should finally fix this issue: esphome/issues#3982

@PolarGoose
Copy link
Author

@LarsStegman,
Nice, then there is even a real use case for this already.
From the issue that you have mentioned I see that the ESP Home uses the glmnet/Dsmr fork of this library. It means that we will also need to coordinate with the fork owner about merging these changes into his fork.
I would like to chat with you about it, could you please contact me to my [email protected]?

@glmnet
Copy link

glmnet commented Nov 16, 2023

Thanks! I will like this PR be tested in ESPHome before pushing a version

@LarsStegman
Copy link

@PolarGoose will you continue the work on this PR?

@PolarGoose
Copy link
Author

I want to finish this pull request. However, I don't know much about ESPHome and how it can be tested.
@LarsStegman and @glmnet, can you test these changes on ESPHome after I finish them?

@LarsStegman
Copy link

I have no idea how to do that yet, but I can try.

@PolarGoose
Copy link
Author

I have no idea how to do that yet, but I can try.

@glmnet, could you please help us with the testing when the pull request is finished?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants