-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the parser compile for Windows and Linux machines #53
base: master
Are you sure you want to change the base?
Make the parser compile for Windows and Linux machines #53
Conversation
* Replace the usage of Arduino String with std::string * Add a unit test project to test the parser
This is great! When this is merged, ESPHome can be updated to use the new version. This should finally fix this issue: esphome/issues#3982 |
@LarsStegman, |
Thanks! I will like this PR be tested in ESPHome before pushing a version |
@PolarGoose will you continue the work on this PR? |
I want to finish this pull request. However, I don't know much about |
I have no idea how to do that yet, but I can try. |
@glmnet, could you please help us with the testing when the pull request is finished? |
Description
I have tried the proposal from @matthijskooijman and managed to make the parser compile and work on Windows and Linux machines. I have only tested it on Windows, but there shouldn't be any problems with Linux.
This can be very beneficial because the parser can be used on Raspberry Pi and other Linux-based embedded boards, for example.
Content of the pull request