Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if event is cancelable before calling preventDefault #132

Merged
merged 4 commits into from
Dec 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,4 @@ projects/angular-resizable-element/package.json
# System Files
.DS_Store
Thumbs.db
package-lock.json
Original file line number Diff line number Diff line change
Expand Up @@ -321,13 +321,8 @@ export class ResizableDirective implements OnInit, OnDestroy {
this.mousemove
).pipe(
tap(({ event }) => {
if (currentResize) {
try {
event.preventDefault();
} catch (e) {
// just adding try-catch not to see errors in console if there is a passive listener for same event somewhere
// browser does nothing except of writing errors to console
}
if (currentResize && event.cancelable) {
event.preventDefault();
}
}),
share()
Expand Down