Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cssClasses): Gives classes to main element depend on state #44

Merged
merged 2 commits into from
Feb 28, 2017

Conversation

Vi-dot
Copy link

@Vi-dot Vi-dot commented Feb 28, 2017

Gives css classes to main element to easily change design depending on current state.

  • resize-hover (when cursor is shown)
  • resize-active (when resizing)
  • resize-left /-right / -top / -bottom (to know which edge is activated)

@Vi-dot Vi-dot changed the title Element classes feat(cssClasses): Gives classes to main element depend on state Feb 28, 2017
@codecov-io
Copy link

Codecov Report

Merging #44 into master will increase coverage by 0.12%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   96.33%   96.46%   +0.12%     
==========================================
  Files           4        4              
  Lines         191      198       +7     
  Branches       34       34              
==========================================
+ Hits          184      191       +7     
  Misses          3        3              
  Partials        4        4
Impacted Files Coverage Δ
src/resizable.directive.ts 96.06% <100%> (+0.16%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0017fa4...8e3f108. Read the comment docs.

@mattlewis92 mattlewis92 merged commit cd07766 into mattlewis92:master Feb 28, 2017
@mattlewis92
Copy link
Owner

Awesome, thank you! 👍

@Vi-dot
Copy link
Author

Vi-dot commented Feb 28, 2017

But this one is not perfect, the class resize-active has some bugs.

@mattlewis92
Copy link
Owner

Ah yes, this should fix it: 1427eec

@mattlewis92
Copy link
Owner

Released as 0.7.0 🎉

@Vi-dot
Copy link
Author

Vi-dot commented Feb 28, 2017

Fast integration ! Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants