Enabled absolute positionning of the cloned node #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
==========================================
+ Coverage 96.06% 96.15% +0.08%
==========================================
Files 4 4
Lines 229 234 +5
Branches 40 41 +1
==========================================
+ Hits 220 225 +5
Misses 4 4
Partials 5 5
Continue to review full report at Codecov.
|
mattlewis92
requested changes
Mar 8, 2017
There was a problem hiding this comment.
This looks great, thank you!
Would you also be able to add a basic integration test for the functionality you added?
- create a new component in the test file like this
- apply the layout changes from this commit
- Prefix the CSS transform property with
-webkit-so it works - use the new option to position the element absolutely
- finally add a test that asserts that the position of the ghost element is correct. You can access the ghost element and assert its styles like this
src/resizable.directive.ts
Outdated
| @@ -213,6 +232,11 @@ export class Resizable implements OnInit, OnDestroy, AfterViewInit { | |||
| @Input() resizeCursorPrecision: number = 3; | |||
|
|
|||
| /** | |||
| * If we want to position cloned node with absolute position | |||
| */ | |||
| @Input() enableAbsolutePositioning: boolean = false; | |||
There was a problem hiding this comment.
To make this more verbose, can you rename this to
@Input() ghostElementPositioning: 'fixed' | 'absolute' = 'fixed';
mattlewis92
approved these changes
Mar 13, 2017
|
Looks great to me, thank you! 😀 Will merge and cut a new release as soon as I'm near a computer. |
|
Sorry about the delay, released as 0.8.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
We find an issue when using enableGhostResizing in a specific case when we have a container wich contain the element and a scale3D on it.
The cloned element will not be at the same place.
Here is a fix for it.