Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: double creation fix #71

Closed
wants to merge 1 commit into from
Closed

fix: double creation fix #71

wants to merge 1 commit into from

Conversation

nikber84
Copy link

@codecov-io
Copy link

codecov-io commented Oct 27, 2017

Codecov Report

Merging #71 into master will not change coverage.
The diff coverage is 90.9%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #71   +/-   ##
=======================================
  Coverage   95.47%   95.47%           
=======================================
  Files           4        4           
  Lines         287      287           
  Branches       42       42           
=======================================
  Hits          274      274           
  Misses          8        8           
  Partials        5        5
Impacted Files Coverage Δ
src/resizable.directive.ts 96% <90.9%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07e4640...b0ab215. Read the comment docs.

@mattlewis92
Copy link
Owner

Sorry I'm probably being really dumb here, but I can't see how adding currentResize onto the controllers component changes any behaviour, would you mind explaining a bit more about how this fixes the problem you're experiencing. Thanks! 😄

@nikber84 nikber84 closed this Oct 27, 2017
@nikber84 nikber84 deleted the double_creation_fix branch October 27, 2017 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants