Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use translate value in calculation (#72) #76

Merged
merged 3 commits into from
Dec 26, 2017

Conversation

thetravis
Copy link
Contributor

This seems to fix the issue I've been having when using the directive in combination with angular2-draggable.

@codecov-io
Copy link

codecov-io commented Nov 16, 2017

Codecov Report

Merging #76 into master will decrease coverage by 0.83%.
The diff coverage is 62.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
- Coverage   95.45%   94.62%   -0.84%     
==========================================
  Files           4        4              
  Lines         308      316       +8     
  Branches       44       45       +1     
==========================================
+ Hits          294      299       +5     
- Misses          8       10       +2     
- Partials        6        7       +1
Impacted Files Coverage Δ
src/resizable.directive.ts 94.89% <62.5%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71d5a05...38cf6a1. Read the comment docs.

mattlewis92 pushed a commit that referenced this pull request Dec 26, 2017
@mattlewis92 mattlewis92 merged commit f24a746 into mattlewis92:master Dec 26, 2017
@mattlewis92
Copy link
Owner

So sorry about the late reply on this one, I've not had much time for open source lately. I will cut a release shortly with this PR. Thanks for your contribution! 🎉

@thetravis
Copy link
Contributor Author

I see you improved my solution :)

@mattlewis92
Copy link
Owner

Hope that was ok, you've already been waiting over a month and I didn't want to drag it out any longer by just reviewing instead of merging 😄

@thetravis
Copy link
Contributor Author

Don't worry. I just made a dirty fix for my project as it needed to be fixed and I didn't care how at the moment. I'm rather new to web development also. My point was to address this issue and provide a solution of some sort :) Thank you, I think I can soon switch to back to the repo version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants