fix: unsubscribe better. Fixes error when host uses drag / mouse events#82
Merged
mattlewis92 merged 1 commit intomattlewis92:masterfrom Aug 10, 2018
ronlawrence3:master
Merged
fix: unsubscribe better. Fixes error when host uses drag / mouse events#82mattlewis92 merged 1 commit intomattlewis92:masterfrom ronlawrence3:master
mattlewis92 merged 1 commit intomattlewis92:masterfrom
ronlawrence3:master
Conversation
Contributor
Author
|
Found this, which seems to back up what I'm seeing. |
mattlewis92
approved these changes
Aug 10, 2018
Owner
mattlewis92
left a comment
There was a problem hiding this comment.
Ah, I've seen this kind of error before as well, makes sense. Travis is having some issues at the moment, will merge once it's backup
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
=========================================
- Coverage 94.83% 94.8% -0.04%
=========================================
Files 4 4
Lines 310 308 -2
Branches 48 48
=========================================
- Hits 294 292 -2
Misses 8 8
Partials 8 8
Continue to review full report at Codecov.
|
Owner
|
Released as |
Contributor
Author
|
👍 Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a failure when the host element has handlers for drag events, and only unsubscribes the subscriptions if they were subscribed. I was getting this during drag events:
I'm not sure why the ngOnDestroy was called without the subscriptions being there, but this fixes the error.