-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(resizable-directive): browser check for angular universal #83
Conversation
Because it doesn't know what document is Fixes 'ReferenceError: document is not defined'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Looks like it was working until the previous version, I should probably try and add a universal smoke test to the CI build somewhere to prevent this happening again
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
==========================================
+ Coverage 95.94% 95.97% +0.02%
==========================================
Files 4 4
Lines 296 298 +2
Branches 29 29
==========================================
+ Hits 284 286 +2
Misses 8 8
Partials 4 4
Continue to review full report at Codecov.
|
All fixed. If you would be so kind to merge and release, you‘ll get a virtual beer directly from the Oktoberfest brewery next to me. |
Perfect, thank you! Cutting a new release momentarily 🎉 |
Because it doesn't know what document is
Fixes 'ReferenceError: document is not defined'