Add smartcase to the regex engine. #5208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implement smart case using (?c), this activates ignore case until an upper char is present (not escape or modifier etc..)
I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.
mawww
reviewed
Jul 30, 2024
mawww
reviewed
Jul 30, 2024
mawww
reviewed
Jul 30, 2024
mawww
requested changes
Jul 30, 2024
mawww
reviewed
Jul 30, 2024
I have addressed your comments. I have also modified it to also make an uppercase char alter existing character classes (otherwise the behaviour of character classes would depend on whether they were before or after the uppercase). A couple of tests and a line in the modifier part of the docs. The only thing to emphasise is that character classes will depend on smart case but will not themselves trigger it. e.g. [A-Z] will not count as an uppercase. |
mawww
requested changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of smart case for regex, using (?c) as a modifier flag.
I believe completes feature request: #4856