Fix checkbox boolean return breaking radio button value.#33
Closed
ryanmaxwell wants to merge 1 commit intomaxatwork:masterfrom
Closed
Fix checkbox boolean return breaking radio button value.#33ryanmaxwell wants to merge 1 commit intomaxatwork:masterfrom
ryanmaxwell wants to merge 1 commit intomaxatwork:masterfrom
Conversation
Maxim's commit #985a3f3214 Returning boolean values from checkboxes was breaking radio buttons serialization/deserialization when value="true" (string). This fixes that regression.
Owner
|
Closing this because the original regression from this PR is already fixed in the current codebase. The key behavior here was that a checked radio should serialize to its string value, and the current implementation already does that in packages/dom/src/index.ts, with regression coverage in packages/dom/test/dom.test.ts. That part is aligned with browser form submission semantics. The only remaining open question is whether we want to keep the legacy checkbox/radio "true"/"false" boolean coercion behavior, but that is a separate API/design discussion rather than something this 2012-era PR should stay open for. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maxim's commit #985a3f3214 Returning boolean values from checkboxes was
breaking radio buttons serialization/deserialization when value="true"
(string). This fixes that regression.