Form fields named 'name' or 'id' break the form traversal.#43
Closed
jakefeasel wants to merge 1 commit intomaxatwork:masterfrom
Closed
Form fields named 'name' or 'id' break the form traversal.#43jakefeasel wants to merge 1 commit intomaxatwork:masterfrom
jakefeasel wants to merge 1 commit intomaxatwork:masterfrom
Conversation
…onfuse the form traversal.
Owner
|
The current objectToForm/js2form traversal handles literal name and id field names correctly, and I added a direct regression test in packages/js2form/test/js2form.test.ts. Closing this legacy PR as already covered in the modern codebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit ensures that the property being checked is a string, rather than an object.
See this jsfiddle for demonstration of the problem:
http://jsfiddle.net/KJyCq/
And this jsfiddle (identical except using my modified version), showing it working:
http://jsfiddle.net/KJyCq/1/