fixes release pipeline to add missing env variables #1099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Caution Review failedThe pull request is closed. 📝 WalkthroughSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughA GitHub Actions workflow configuration update that passes two new AWS-related environment secrets (AWS_S3_BUCKET and AWS_BEDROCK_ROLE_ARN) to the core release step, expanding external system integration capabilities for the release pipeline. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Comment |
Contributor
🧪 Test Suite AvailableThis PR can be tested by a repository admin. |
akshaydeo
deleted the
12-16-fixes_release_pipeline_to_add_missing_env_variables
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add AWS S3 bucket and Bedrock role ARN secrets to the core release workflow.
Changes
AWS_S3_BUCKETandAWS_BEDROCK_ROLE_ARNenvironment variables to the core release jobType of change
Affected areas
How to test
The changes can be verified by running a core release job and confirming that the AWS credentials are properly passed to the release script.
Breaking changes
Security considerations
This PR adds access to AWS secrets in the release pipeline. These secrets are properly handled through GitHub's secret management system and only exposed to the release script during execution.
Checklist