Skip to content

Conversation

@akshaydeo
Copy link
Contributor

@akshaydeo akshaydeo commented Dec 15, 2025

Summary

Briefly explain the purpose of this PR and the problem it solves.

Changes

  • What was changed and why
  • Any notable design decisions or trade-offs

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore/CI

Affected areas

  • Core (Go)
  • Transports (HTTP)
  • Providers/Integrations
  • Plugins
  • UI (Next.js)
  • Docs

How to test

Describe the steps to validate this change. Include commands and expected outcomes.

# Core/Transports
go version
go test ./...

# UI
cd ui
pnpm i || npm i
pnpm test || npm test
pnpm build || npm run build

If adding new configs or environment variables, document them here.

Screenshots/Recordings

If UI changes, add before/after screenshots or short clips.

Breaking changes

  • Yes
  • No

If yes, describe impact and migration instructions.

Related issues

Link related issues and discussions. Example: Closes #123

Security considerations

Note any security implications (auth, secrets, PII, sandboxing, etc.).

Checklist

  • I read docs/contributing/README.md and followed the guidelines
  • I added/updated tests where appropriate
  • I updated documentation where needed
  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

@akshaydeo akshaydeo merged commit 7ad009b into main Dec 15, 2025
7 of 8 checks passed
@akshaydeo akshaydeo deleted the 12-16-removes_azure_from_batch_unsupported branch December 15, 2025 19:55
@github-actions
Copy link
Contributor

🧪 Test Suite Available

This PR can be tested by a repository admin.

Run tests for PR #1100

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 15, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Updated batch test execution to run exclusively for Azure provider, with additional safeguards to ensure proper test environment configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

The changes add an Azure-only provider filter to the RunBatchUnsupportedTest function in the test utilities, causing the test to skip execution for non-Azure providers through early returns at two strategic points.

Changes

Cohort / File(s) Change Summary
Batch test provider filtering
core/internal/testutil/batch.go
Added provider filter logic to restrict RunBatchUnsupportedTest execution to Azure only; implemented via early returns when testConfig.Provider is not Azure

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Simple conditional early returns with no complex logic
  • Straightforward provider check applied consistently in two locations
  • No changes to exported signatures or core test flow

Poem

🐰 A filter hops in twice so neat,
Azure tests alone will greet,
Others skip with gentle care,
Batch providers find their lair! ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 12-16-removes_azure_from_batch_unsupported

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a322564 and 7ced31c.

📒 Files selected for processing (1)
  • core/internal/testutil/batch.go (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Files API Support

2 participants