-
Notifications
You must be signed in to change notification settings - Fork 186
increase timeout limit to 48 hours for providers #1106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increase timeout limit to 48 hours for providers #1106
Conversation
📝 WalkthroughSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughThe network configuration form now shows the timeout value in a human-readable format and the validation schema raises the maximum Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Comment |
🧪 Test Suite AvailableThis PR can be tested by a repository admin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
ui/app/workspace/providers/fragments/networkFormFragment.tsx(3 hunks)ui/lib/types/schemas.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**
⚙️ CodeRabbit configuration file
always check the stack if there is one for the current PR. do not give localized reviews for the PR, always see all changes in the light of the whole stack of PRs (if there is a stack, if there is no stack you can continue to make localized suggestions/reviews)
Files:
ui/lib/types/schemas.tsui/app/workspace/providers/fragments/networkFormFragment.tsx
🧬 Code graph analysis (1)
ui/app/workspace/providers/fragments/networkFormFragment.tsx (1)
ui/components/ui/form.tsx (1)
FormDescription(164-164)
🔇 Additional comments (2)
ui/app/workspace/providers/fragments/networkFormFragment.tsx (2)
4-4: LGTM!The import of
FormDescriptionis correctly added and necessary for displaying the human-readable timeout description.
155-155: LGTM with dependency on function refactor.The usage of
FormDescriptionwithsecondsToHumanReadableis correct. However, ensure that the suggested refactor forsecondsToHumanReadableis applied to handle edge cases gracefully.
b441e74 to
c429649
Compare
Merge activity
|

Summary
Added a human-readable time display for request timeout settings in the network configuration form and increased the maximum allowed timeout value.
Changes
secondsToHumanReadableutility function that converts seconds to a human-readable time format (e.g., "2 days 3 hours 45 minutes 30 seconds")FormDescriptioncomponent to display the human-readable time below the timeout input fieldType of change
Affected areas
How to test
Screenshots/Recordings
N/A
Breaking changes
Related issues
N/A
Security considerations
N/A
Checklist
docs/contributing/README.mdand followed the guidelines