Skip to content

Conversation

@akshaydeo
Copy link
Contributor

@akshaydeo akshaydeo commented Dec 16, 2025

Summary

Added a human-readable time display for request timeout settings in the network configuration form and increased the maximum allowed timeout value.

Changes

  • Added a secondsToHumanReadable utility function that converts seconds to a human-readable time format (e.g., "2 days 3 hours 45 minutes 30 seconds")
  • Added a FormDescription component to display the human-readable time below the timeout input field
  • Increased the maximum allowed request timeout from 3600 seconds (1 hour) to 172800 seconds (48 hours)

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore/CI

Affected areas

  • Core (Go)
  • Transports (HTTP)
  • Providers/Integrations
  • Plugins
  • UI (Next.js)
  • Docs

How to test

  1. Navigate to the provider settings page
  2. Go to the Network tab
  3. Change the default request timeout value
  4. Verify that the human-readable time display updates correctly
  5. Try setting values above the previous limit (3600 seconds) and confirm they're accepted up to 48 hours
# UI
cd ui
pnpm i
pnpm dev

Screenshots/Recordings

N/A

Breaking changes

  • No

Related issues

N/A

Security considerations

N/A

Checklist

  • I read docs/contributing/README.md and followed the guidelines
  • I added/updated tests where appropriate
  • I updated documentation where needed
  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 16, 2025

📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Timeout values now display in a human-readable format (e.g., minutes/hours) next to the timeout input field, improving clarity when configuring request timeouts.
    • Maximum network request timeout limit increased to 48 hours (previously 1 hour), allowing much longer allowable request durations for configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

The network configuration form now shows the timeout value in a human-readable format and the validation schema raises the maximum default_request_timeout_in_seconds from 3,600 to 172,800 seconds (48 hours).

Changes

Cohort / File(s) Summary
Network Form UI Enhancement
ui/app/workspace/providers/fragments/networkFormFragment.tsx
Added FormDescription import, introduced secondsToHumanReadable(seconds: number) utility, and rendered <FormDescription>{secondsToHumanReadable(field.value)}</FormDescription> next to the Timeout (seconds) input.
Validation Schema Update
ui/lib/types/schemas.ts
Increased default_request_timeout_in_seconds max from 3600 to 172800 and updated the validation message to reflect a 48-hour limit.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Check secondsToHumanReadable() for edge cases (0, negative, very large values).
  • Confirm UI formatting/localization expectations for human-readable durations.
  • Verify the schema change aligns with intended constraints and UI validation messaging.

Poem

🐰 I nibble code in quiet light,

I turn cold seconds warm and bright.
From minutes small to two-day cheer,
The timeout reads so clear and near.
Hooray—forty-eight hours here! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The PR title accurately describes the main change: increasing the timeout limit to 48 hours for providers, which aligns with the 172800-second maximum limit increase in the changeset.
Description check ✅ Passed The PR description is comprehensive and follows the template structure, including Summary, Changes, Type of change, Affected areas, How to test, Breaking changes, and Checklist sections with appropriate selections.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 12-16-increase_timeout_limit_to_48_hours_for_providers

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b441e74 and c429649.

📒 Files selected for processing (2)
  • ui/app/workspace/providers/fragments/networkFormFragment.tsx (3 hunks)
  • ui/lib/types/schemas.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • ui/lib/types/schemas.ts
  • ui/app/workspace/providers/fragments/networkFormFragment.tsx

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

🧪 Test Suite Available

This PR can be tested by a repository admin.

Run tests for PR #1106

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@akshaydeo akshaydeo marked this pull request as ready for review December 16, 2025 09:21
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d818172 and b441e74.

📒 Files selected for processing (2)
  • ui/app/workspace/providers/fragments/networkFormFragment.tsx (3 hunks)
  • ui/lib/types/schemas.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

always check the stack if there is one for the current PR. do not give localized reviews for the PR, always see all changes in the light of the whole stack of PRs (if there is a stack, if there is no stack you can continue to make localized suggestions/reviews)

Files:

  • ui/lib/types/schemas.ts
  • ui/app/workspace/providers/fragments/networkFormFragment.tsx
🧬 Code graph analysis (1)
ui/app/workspace/providers/fragments/networkFormFragment.tsx (1)
ui/components/ui/form.tsx (1)
  • FormDescription (164-164)
🔇 Additional comments (2)
ui/app/workspace/providers/fragments/networkFormFragment.tsx (2)

4-4: LGTM!

The import of FormDescription is correctly added and necessary for displaying the human-readable timeout description.


155-155: LGTM with dependency on function refactor.

The usage of FormDescription with secondsToHumanReadable is correct. However, ensure that the suggested refactor for secondsToHumanReadable is applied to handle edge cases gracefully.

@akshaydeo akshaydeo force-pushed the 12-16-increase_timeout_limit_to_48_hours_for_providers branch from b441e74 to c429649 Compare December 16, 2025 10:16
Copy link
Contributor Author

akshaydeo commented Dec 16, 2025

Merge activity

  • Dec 16, 10:31 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Dec 16, 10:31 AM UTC: @akshaydeo merged this pull request with Graphite.

@akshaydeo akshaydeo merged commit 991b5aa into main Dec 16, 2025
9 checks passed
@akshaydeo akshaydeo deleted the 12-16-increase_timeout_limit_to_48_hours_for_providers branch December 16, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants