-
Notifications
You must be signed in to change notification settings - Fork 197
refactor: openai and mistral audio refactored #1112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: openai and mistral audio refactored #1112
Conversation
|
Caution Review failedThe pull request is closed. 📝 WalkthroughSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughMistral transcription gained an optional Stream flag and unified multipart form construction for streaming and non-streaming requests. OpenAI provider logic was refactored to extract centralized handlers for Speech, Transcription, and Embedding (including streaming variants) with shared parameters and optional converter hooks. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (6)
Comment |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
c6d091a to
f7fd3bf
Compare
332bc02 to
eeb6bc7
Compare
eeb6bc7 to
d6c142a
Compare
f7fd3bf to
464bc24
Compare
d6c142a to
f109532
Compare
464bc24 to
e8b50ea
Compare
Merge activity
|

Summary
Refactors audio processing code to reduce duplication and improve maintainability across providers by extracting shared functionality into reusable handler functions.
Changes
createMistralTranscriptionStreamMultipartBodyandcreateMistralTranscriptionMultipartBodyinto a single functionStreamparameter to the Mistral transcription request structure for better controlType of change
Affected areas
How to test
Test the audio processing functionality with both OpenAI and Mistral providers:
Breaking changes
Related issues
Improves code maintainability and reduces duplication in audio processing code.
Security considerations
No security implications as this is a refactoring of existing functionality.
Checklist