Skip to content

Conversation

@akshaydeo
Copy link
Contributor

@akshaydeo akshaydeo commented Dec 17, 2025

Summary

Added UnknownRequest type to the Bifrost schema, wrapped the Sidebar component in a Suspense boundary, and improved the styling of destructive alerts for better visual consistency.

Changes

  • Added UnknownRequest as a new RequestType in the Bifrost schema to handle unknown request types
  • Wrapped the Sidebar component in a React Suspense boundary with a null fallback to prevent rendering blocking
  • Enhanced the styling of destructive alerts to match the design system's color scheme and improve readability in both light and dark modes

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore/CI

Affected areas

  • Core (Go)
  • Transports (HTTP)
  • Providers/Integrations
  • Plugins
  • UI (Next.js)
  • Docs

How to test

# Core/Transports
go version
go test ./...

# UI
cd ui
pnpm i
pnpm test
pnpm build

Verify that:

  1. The sidebar loads correctly and doesn't block page rendering
  2. Destructive alerts display with the updated styling in both light and dark modes
  3. The application correctly handles unknown request types

Breaking changes

  • Yes
  • No

Related issues

Improves UI rendering performance and error handling

Security considerations

No security implications.

Checklist

  • I read docs/contributing/README.md and followed the guidelines
  • I added/updated tests where appropriate
  • I updated documentation where needed
  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 17, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Summary by CodeRabbit

  • Style
    • Enhanced destructive alert styling with improved dark mode support, including updated border, background, and text colors for better visual consistency across themes.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

This pull request introduces a new UnknownRequest constant to the request type enum, refactors sidebar tab detection from useSearchParams to useQueryState hook, expands destructive alert variant styling, and applies formatting adjustments to the client layout component.

Changes

Cohort / File(s) Summary
Enum Constants
core/schemas/bifrost.go
Added UnknownRequest constant of type RequestType with value "unknown" to expand recognized request types.
State Management Refactoring
ui/components/sidebar.tsx
Replaced useSearchParams-based tab detection with useQueryState("tab") hook from nuqs; removed searchParams prop from SidebarItemView and updated all subitem active-state checks to use centralized currentConfigTab.
Styling Updates
ui/components/ui/alert.tsx
Expanded destructive variant with comprehensive light/dark mode border, background, text color, and nested SVG styling; removed trailing newline.
Formatting
ui/app/clientLayout.tsx
Applied whitespace and indentation adjustments with no functional impact.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Attention areas:
    • ui/components/sidebar.tsx: Verify all active-state comparisons against currentConfigTab are correct and that useQueryState initialization properly handles the tab query parameter.
    • ui/components/ui/alert.tsx: Confirm destructive styling renders consistently across light/dark modes and all nested elements (SVG, text) display correctly.

Poem

🐰 A constant unknown joins the request brigade,
Tabs now dance with query state so sage,
Alerts bloom vibrant in their destructive guise,
While layouts align their spacing just right—
Small changes bloom together, what a sight!

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 12-17-build_fixes

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5692d16 and 4397e5d.

📒 Files selected for processing (4)
  • core/schemas/bifrost.go (1 hunks)
  • ui/app/clientLayout.tsx (1 hunks)
  • ui/components/sidebar.tsx (3 hunks)
  • ui/components/ui/alert.tsx (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

🧪 Test Suite Available

This PR can be tested by a repository admin.

Run tests for PR #1123

@akshaydeo akshaydeo marked this pull request as ready for review December 17, 2025 13:37
Copy link
Collaborator

Pratham-Mishra04 commented Dec 17, 2025

Merge activity

  • Dec 17, 1:41 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Dec 17, 1:42 PM UTC: @Pratham-Mishra04 merged this pull request with Graphite.

@Pratham-Mishra04 Pratham-Mishra04 merged commit 6fc2461 into main Dec 17, 2025
8 checks passed
@Pratham-Mishra04 Pratham-Mishra04 deleted the 12-17-build_fixes branch December 17, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants