Skip to content

Conversation

@akshaydeo
Copy link
Contributor

@akshaydeo akshaydeo commented Dec 17, 2025

Summary

Upgrade macOS SDK from 11.3 to 12.3 in the cross-compilation setup script.

Changes

  • Updated macOS SDK version from 11.3 to 12.3 throughout the installation script
  • Updated SDK download URLs to point to the newer version
  • Updated all compiler wrapper scripts to reference the new SDK path

Type of change

  • Chore/CI

Affected areas

  • Core (Go)

How to test

Verify that cross-compilation for macOS targets works correctly with the updated SDK:

# Run the cross-compilation workflow or manually test with:
.github/workflows/scripts/install-cross-compilers.sh
# Then attempt to build for macOS targets

Breaking changes

  • No

Security considerations

This change only updates the SDK version used for cross-compilation and doesn't introduce any security implications.

Checklist

  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 17, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated macOS build toolchain to a newer SDK version for improved compatibility and stability in cross-compilation environments.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

The pull request updates the macOS SDK version from 11.3 to 12.3 in the cross-compiler installation workflow script. Changes include updating SDK directory paths, download URLs, tar file references, and wrapper script sysroot pointers to reflect the new SDK version.

Changes

Cohort / File(s) Summary
macOS SDK Version Bump
.github/workflows/scripts/install-cross-compilers.sh
Updated macOS SDK version from 11.3 to 12.3 across all references: SDK_DIR path, SDK_URL download link, tar extraction operations, and wrapper script sysroot pointers to /opt/MacOSX12.3.sdk.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify the new SDK version (12.3) is correct and available at the specified URL
  • Confirm all path references use consistent naming (MacOSX12.3.sdk)
  • Validate tar file naming and extraction logic changes

Poem

🐰 From eleven to twelve, the SDK takes flight,
Cross-compilers bundled, everything just right,
Paths and URLs dance in perfect sync,
A sysroot update in a blink,
macOS twelve-three, brighter than before! ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 12-17-adds_new_macos_update_for_new_golang_version

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 835ddca and 859db4c.

📒 Files selected for processing (1)
  • .github/workflows/scripts/install-cross-compilers.sh (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

🧪 Test Suite Available

This PR can be tested by a repository admin.

Run tests for PR #1126

@akshaydeo akshaydeo marked this pull request as ready for review December 17, 2025 17:38
@akshaydeo akshaydeo merged commit 35721f1 into main Dec 17, 2025
10 of 11 checks passed
@akshaydeo akshaydeo deleted the 12-17-adds_new_macos_update_for_new_golang_version branch December 17, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants