Skip to content

Conversation

@qwerty-dvorak
Copy link
Contributor

@qwerty-dvorak qwerty-dvorak commented Dec 22, 2025

Summary

Update the vision model used in Huggingface provider tests from novita/zai-org/GLM-4.6V-Flash to cohere/CohereLabs/aya-vision-32b.

Changes

  • Changed the vision model in the comprehensive test configuration for Huggingface provider tests to use Cohere's Aya Vision model instead of GLM-4.6V-Flash

Type of change

  • Chore/CI

Affected areas

  • Core (Go)
  • Providers/Integrations

How to test

Run the Huggingface provider tests to ensure they pass with the new vision model:

source .env && go test ./core/providers/huggingface 

Breaking changes

  • No

Security considerations

N/A

Checklist

  • I read docs/contributing/README.md and followed the guidelines
  • I added/updated tests where appropriate
  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 22, 2025

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Updated test configuration to use an alternative vision model for comprehensive validation and compatibility testing.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

A test configuration parameter in the HuggingFace provider test file was updated. The VisionModel value used in a test case was changed from one model identifier to another, with no modifications to test logic or control flow.

Changes

Cohort / File(s) Summary
Test Configuration Update
core/providers/huggingface/huggingface_test.go
Updated VisionModel parameter in comprehensive test configuration from "novita/zai-org/GLM-4.6V-Flash" to "cohere/CohereLabs/aya-vision-32b"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

This is a straightforward test parameter update with no logic changes or behavioral modifications.

Poem

🐰 A model swap, so small and neat,
From vision old to vision fleet,
The test runs true, the change is light,
Cohere's gaze now shines so bright! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating the Huggingface vision model in tests from GLM-4.6V-Flash to Aya Vision.
Description check ✅ Passed The PR description follows the template with all required sections completed: summary, changes, type of change, affected areas, testing instructions, breaking changes, security considerations, and checklist.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 12-22-fix_update_hugging_face_vision_model

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8e050bd and 0743a3c.

📒 Files selected for processing (1)
  • core/providers/huggingface/huggingface_test.go
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

always check the stack if there is one for the current PR. do not give localized reviews for the PR, always see all changes in the light of the whole stack of PRs (if there is a stack, if there is no stack you can continue to make localized suggestions/reviews)

Files:

  • core/providers/huggingface/huggingface_test.go
🧠 Learnings (4)
📚 Learning: 2025-12-09T17:07:42.007Z
Learnt from: qwerty-dvorak
Repo: maximhq/bifrost PR: 1006
File: core/schemas/account.go:9-18
Timestamp: 2025-12-09T17:07:42.007Z
Learning: In core/schemas/account.go, the HuggingFaceKeyConfig field within the Key struct is currently unused and reserved for future Hugging Face inference endpoint deployments. Do not flag this field as missing from OpenAPI documentation or require its presence in the API spec until the feature is actively implemented and used. When the feature is added, update the OpenAPI docs accordingly; otherwise, treat this field as non-breaking and not part of the current API surface.

Applied to files:

  • core/providers/huggingface/huggingface_test.go
📚 Learning: 2025-12-15T10:16:21.909Z
Learnt from: qwerty-dvorak
Repo: maximhq/bifrost PR: 1006
File: core/providers/huggingface/huggingface_test.go:12-63
Timestamp: 2025-12-15T10:16:21.909Z
Learning: In provider tests under core/providers/<provider>/*_test.go, do not require or flag the use of defer for Shutdown(); instead call client.Shutdown() at the end of each test function. This pattern appears consistent across all provider tests. Apply this rule only within this path; for other tests or resources, defer may still be appropriate.

Applied to files:

  • core/providers/huggingface/huggingface_test.go
📚 Learning: 2025-12-15T10:34:13.855Z
Learnt from: qwerty-dvorak
Repo: maximhq/bifrost PR: 1006
File: core/providers/huggingface/chat.go:370-389
Timestamp: 2025-12-15T10:34:13.855Z
Learning: In the HuggingFace provider (core/providers/huggingface/), streaming tool call data arrives as a single delta chunk with all fields (id, type, function.name, function.arguments) present at once. Do not implement accumulation logic across deltas for streaming tool calls in this codebase; rely on single-chunk data as the guaranteed behavior. If there is existing accumulation logic in this directory, remove it or guard it behind this assumption.

Applied to files:

  • core/providers/huggingface/huggingface_test.go
📚 Learning: 2025-12-19T09:26:54.961Z
Learnt from: qwerty-dvorak
Repo: maximhq/bifrost PR: 1006
File: core/providers/utils/utils.go:1050-1051
Timestamp: 2025-12-19T09:26:54.961Z
Learning: Update streaming end-marker handling so HuggingFace is treated as a non-[DONE] provider for backends that do not emit a DONE marker (e.g., meta llama on novita). In core/providers/utils/utils.go, adjust ProviderSendsDoneMarker() (or related logic) to detect providers that may not emit DONE and avoid relying on DONE as the sole end signal. Add tests to cover both DONE-emitting and non-DONE backends, with clear documentation in code comments explaining the rationale and any fallback behavior.

Applied to files:

  • core/providers/huggingface/huggingface_test.go
🔇 Additional comments (1)
core/providers/huggingface/huggingface_test.go (1)

27-27: Verify the new model is compatible with the test suite.

The new model "cohere/CohereLabs/aya-vision-32b" is an accessible, publicly available vision-language model on HuggingFace that supports all required capabilities (image URLs, base64 images, and multiple image processing). However, the original review incorrectly references the previous model as "novita/zai-org/GLM-4.6V-Flash"—the correct reference should be "zai-org/GLM-4.6V-Flash" (without the "novita/" namespace).

Confirm the test passes with the new model and clarify whether the previous model was deprecated or had functionality issues that prompted this change.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

🧪 Test Suite Available

This PR can be tested by a repository admin.

Run tests for PR #1159

@qwerty-dvorak qwerty-dvorak marked this pull request as ready for review December 22, 2025 18:13
Copy link
Collaborator

Pratham-Mishra04 commented Dec 23, 2025

Merge activity

  • Dec 23, 7:10 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Dec 23, 7:10 AM UTC: @Pratham-Mishra04 merged this pull request with Graphite.

@Pratham-Mishra04 Pratham-Mishra04 merged commit d526cf1 into main Dec 23, 2025
11 checks passed
@Pratham-Mishra04 Pratham-Mishra04 deleted the 12-22-fix_update_hugging_face_vision_model branch December 23, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants