Skip to content

fix: thought signature handling in anthropic #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pratham-Mishra04 merged 1 commit into from
Dec 23, 2025
Merged

fix: thought signature handling in anthropic #1162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 18 additions & 23 deletions core/providers/anthropic/responses.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2156,7 +2156,6 @@ func convertSingleAnthropicMessageToBifrostMessagesGrouped(msg *AnthropicMessage
// Helper function to convert Anthropic content blocks to Bifrost ResponsesMessages, grouping text and tool_use blocks
func convertAnthropicContentBlocksToResponsesMessagesGrouped(contentBlocks []AnthropicContentBlock, role *schemas.ResponsesMessageRoleType, isOutputMessage bool) []schemas.ResponsesMessage {
var bifrostMessages []schemas.ResponsesMessage
var reasoningContentBlocks []schemas.ResponsesMessageContentBlock
var accumulatedTextContent []schemas.ResponsesMessageContentBlock
var pendingToolUseBlocks []*AnthropicContentBlock // Accumulate tool_use blocks

Expand Down Expand Up @@ -2208,12 +2207,21 @@ func convertAnthropicContentBlocksToResponsesMessagesGrouped(contentBlocks []Ant

case AnthropicContentBlockTypeThinking:
if block.Thinking != nil {
// Collect reasoning blocks without flushing accumulated text/tool blocks
reasoningContentBlocks = append(reasoningContentBlocks, schemas.ResponsesMessageContentBlock{
Type: schemas.ResponsesOutputMessageContentTypeReasoning,
Text: block.Thinking,
Signature: block.Signature,
})
bifrostMsg := schemas.ResponsesMessage{
ID: schemas.Ptr("rs_" + utils.GetRandomString(50)),
Type: schemas.Ptr(schemas.ResponsesMessageTypeReasoning),
Role: role,
Content: &schemas.ResponsesMessageContent{
ContentBlocks: []schemas.ResponsesMessageContentBlock{
{
Type: schemas.ResponsesOutputMessageContentTypeReasoning,
Text: block.Thinking,
Signature: block.Signature,
},
},
},
}
bifrostMessages = append(bifrostMessages, bifrostMsg)
}

case AnthropicContentBlockTypeRedactedThinking:
Expand Down Expand Up @@ -2296,20 +2304,6 @@ func convertAnthropicContentBlocksToResponsesMessagesGrouped(contentBlocks []Ant
}
}

// For Bedrock compatibility: reasoning blocks must come before text/tool blocks
// If we have reasoning + text/tools, emit reasoning first, then text/tools
// Otherwise emit them separately as before
if len(reasoningContentBlocks) > 0 {
bifrostMsg := schemas.ResponsesMessage{
ID: schemas.Ptr("rs_" + utils.GetRandomString(50)),
Type: schemas.Ptr(schemas.ResponsesMessageTypeReasoning),
Content: &schemas.ResponsesMessageContent{
ContentBlocks: reasoningContentBlocks,
},
}
bifrostMessages = append(bifrostMessages, bifrostMsg)
}

// Flush any remaining pending blocks
if len(accumulatedTextContent) > 0 {
bifrostMsg := schemas.ResponsesMessage{
Expand Down Expand Up @@ -3362,8 +3356,9 @@ func convertContentBlockToAnthropic(block schemas.ResponsesMessageContentBlock)
case schemas.ResponsesOutputMessageContentTypeReasoning:
if block.Text != nil {
return &AnthropicContentBlock{
Type: AnthropicContentBlockTypeThinking,
Thinking: block.Text,
Type: AnthropicContentBlockTypeThinking,
Thinking: block.Text,
Signature: block.Signature,
}
}
}
Expand Down