Skip to content

Conversation

@akshaydeo
Copy link
Contributor

@akshaydeo akshaydeo commented Jan 5, 2026

Summary

Added support for cluster mode in Bifrost Helm chart by exposing gossip ports and bumped chart version to 1.5.2.

Changes

  • Bumped Helm chart and app version from 1.5.1 to 1.5.2
  • Added conditional gossip TCP and UDP ports to the deployment template when cluster mode is enabled
  • Updated service template to expose gossip ports when cluster mode is enabled
  • Updated Helm chart index with the new 1.5.2 version

Type of change

  • Feature
  • Chore/CI

Affected areas

  • Core (Go)
  • Transports (HTTP)

How to test

Deploy Bifrost with cluster mode enabled and verify that gossip ports are properly exposed:

# Install the chart with cluster mode enabled
helm install bifrost ./helm-charts/bifrost --set bifrost.cluster.enabled=true

# Verify the ports are exposed in the deployment
kubectl get deployment bifrost -o jsonpath='{.spec.template.spec.containers[0].ports}'

# Verify the service exposes the gossip ports
kubectl get service bifrost -o jsonpath='{.spec.ports}'

Breaking changes

  • No

Related issues

Supports cluster mode functionality for horizontal scaling.

Security considerations

Gossip ports should be properly secured in production environments to prevent unauthorized access to cluster communication.

Checklist

  • I added/updated tests where appropriate
  • I updated documentation where needed
  • I verified builds succeed (Go and UI)

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 5, 2026

📝 Walkthrough

Summary by CodeRabbit

  • New Features

    • Added conditional gossip communication ports (TCP/UDP) to deployment and service when cluster mode is enabled.
  • Chores

    • Bumped Bifrost Helm chart version to 1.5.2.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

Version bump from 1.5.1 to 1.5.2 introduces conditional gossip protocol ports (TCP/UDP) to Bifrost's deployment and service templates when cluster mode is enabled, with corresponding chart metadata and index updates.

Changes

Cohort / File(s) Summary
Chart Metadata Updates
helm-charts/bifrost/Chart.yaml, helm-charts/index.yaml
Version and appVersion incremented to 1.5.2; index.yaml appended with new Bifrost v1.5.2 entry and updated generated timestamp
Clustering Support – Port Additions
helm-charts/bifrost/templates/deployment.yaml, helm-charts/bifrost/templates/service.yaml
Added conditional gossip (TCP) and gossip-udp (UDP) container ports when .Values.bifrost.cluster.enabled is true; existing HTTP port unaffected

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A hop toward harmony!

Bifrost bumps to one-point-two,
Gossip ports now whisper through,
Clustering hops, TCP and UDP brew,
When enabled, nodes dance a synchronized cue! 🎭✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR objectives do not align with linked issue #123 (Files API Support); the PR addresses Helm chart gossip ports, which is unrelated to file API functionality. Either link the correct issues related to cluster mode and gossip protocol support, or remove the unrelated Files API Support issue from the PR.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: exposing gossip protocol ports in the Helm chart.
Description check ✅ Passed The description is substantially complete with summary, detailed changes, type of change, affected areas, testing instructions, breaking changes, and security considerations filled out.
Out of Scope Changes check ✅ Passed The PR contains changes strictly scoped to Helm chart configuration for exposing gossip ports when cluster mode is enabled, with no unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 01-05-fixes_helchart_to_expose_gossip_protocol_port

Comment @coderabbitai help to get the list of available commands and usage tips.

@akshaydeo akshaydeo marked this pull request as ready for review January 5, 2026 14:04
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

🧪 Test Suite Available

This PR can be tested by a repository admin.

Run tests for PR #1250

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Fix all issues with AI Agents 🤖
In @helm-charts/bifrost/templates/deployment.yaml:
- Around line 48-55: There are duplicate "gossip" definitions in values.yaml;
remove the redundant entry and consolidate into a single gossip block so that
.Values.bifrost.cluster.gossip.port is defined only once (e.g., keep one gossip:
{ port: 7946, ... } and delete the duplicate); ensure the deployment template
references .Values.bifrost.cluster.gossip.port and the service/gossip UDP/TCP
entries remain unchanged and still point to that single gossip definition.
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 40849c1 and 2d016b2.

📒 Files selected for processing (4)
  • helm-charts/bifrost/Chart.yaml
  • helm-charts/bifrost/templates/deployment.yaml
  • helm-charts/bifrost/templates/service.yaml
  • helm-charts/index.yaml
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

always check the stack if there is one for the current PR. do not give localized reviews for the PR, always see all changes in the light of the whole stack of PRs (if there is a stack, if there is no stack you can continue to make localized suggestions/reviews)

Files:

  • helm-charts/bifrost/templates/deployment.yaml
  • helm-charts/index.yaml
  • helm-charts/bifrost/templates/service.yaml
  • helm-charts/bifrost/Chart.yaml
🔇 Additional comments (4)
helm-charts/bifrost/Chart.yaml (1)

5-6: LGTM! Version bump is consistent.

The version and appVersion are correctly updated to 1.5.2, aligning with the gossip protocol port feature addition in the deployment and service templates.

helm-charts/bifrost/templates/service.yaml (1)

19-28: LGTM! Service ports correctly expose gossip protocol.

The conditional gossip ports (TCP and UDP) are properly configured with targetPort names that match the container ports defined in the deployment template. The configuration allows the gossip protocol to function correctly when cluster mode is enabled.

helm-charts/index.yaml (2)

160-160: Generated timestamp correctly updated.

The index generation timestamp has been appropriately updated to reflect the new chart entry.


4-25: The digest field will be auto-generated by helm repo index, but multiple entries in index.yaml currently have empty digests, indicating the workflow may not have run since the index was last updated.

The helm-release.yml workflow is properly configured to automatically generate SHA256 digests for all chart entries via the helm repo index command (line 79). When the workflow runs, it will populate the digest field for version 1.5.2 and other entries.

However, the fact that multiple chart versions (1.5.2, 1.5.1, and others) already have empty digests in the committed index.yaml suggests this file may be undergoing manual updates or the workflow hasn't executed since the latest index changes. Ensure the workflow completes successfully after these changes are merged to main so the digests are properly generated and published to GitHub Pages.

@akshaydeo akshaydeo merged commit 3f0e4ca into main Jan 5, 2026
11 checks passed
@akshaydeo akshaydeo deleted the 01-05-fixes_helchart_to_expose_gossip_protocol_port branch January 5, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants