feat: plugin context added #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
danpiths
reviewed
Mar 22, 2025
| type Plugin interface { | ||
| PreHook(req *BifrostRequest) (*BifrostRequest, error) | ||
| PostHook(result *CompletionResult) (*CompletionResult, error) | ||
| PreHook(ctx *context.Context, req *BifrostRequest) (*BifrostRequest, error) |
Collaborator
There was a problem hiding this comment.
let us pass in the context object and not a pointer to the context for both the pre and post hook
danpiths
reviewed
Mar 22, 2025
|
|
||
| req, err = plugin.PreHook(req) | ||
| // Create a context with timeout same as the provider/request config | ||
| ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second) |
Collaborator
There was a problem hiding this comment.
we will not create our own context, we shall ask users to pass in the context from the chat/text completion functions. keep it as the first param there. they would pass in their context to the completion functions that we shall use with in the plugin system
This was referenced Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.