Skip to content

move edit and delete to be separate buttons within a note #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phoebejaffe wants to merge 2 commits into
base: main
Choose a base branch
from
Open

move edit and delete to be separate buttons within a note #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d64ef05
move edit and delete to be separate buttons within a note
phoebejaffe Mar 10, 2022
12502e2
rename export title
phoebejaffe Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/views/notes_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ class _NotesViewState extends State<_NotesView> {
value: "export_md",
child: ListTile(
leading: Icon(Icons.receipt_long),
title: Text("export markdown"))),
title: Text("export outline"))),
if (outline.archived) ...[
const PopupMenuItem(
value: "unarchive",
Expand Down
16 changes: 9 additions & 7 deletions lib/widgets/note_item.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,6 @@ class _NoteItemState extends State<NoteItem> {
const PopupMenuItem(
value: "share",
child: ListTile(leading: Icon(Icons.share), title: Text("share"))),
const PopupMenuItem(
value: "edit",
child: ListTile(leading: Icon(Icons.edit), title: Text("edit"))),
const PopupMenuItem(
value: "move",
child: ListTile(
Expand All @@ -118,9 +115,6 @@ class _NoteItemState extends State<NoteItem> {
value: "locate",
child: ListTile(
leading: Icon(Icons.location_pin), title: Text("location"))),
const PopupMenuItem(
value: "delete",
child: ListTile(leading: Icon(Icons.delete), title: Text("delete"))),
if (isTranscribing)
const PopupMenuItem(
child: ListTile(
Expand Down Expand Up @@ -150,7 +144,7 @@ class _NoteItemState extends State<NoteItem> {
Navigator.push(context, MaterialPageRoute(builder: (ct) {
return Scaffold(
appBar: AppBar(
title: const Text("Select Outline"),
title: const Text("Select Outline To Move To"),
),
body: OutlinesList(
excludeItem: note.outlineId,
Expand Down Expand Up @@ -310,6 +304,14 @@ class _NoteItemState extends State<NoteItem> {
TextStyle(color: Theme.of(context).hintColor),
),
date: dateCreated!),
IconButton(
tooltip: "edit",
onPressed: _editNoteDetails,
icon: const Icon(Icons.edit)),
IconButton(
tooltip: "delete",
onPressed: _deleteNote,
icon: const Icon(Icons.delete)),
PopupMenuButton(
tooltip: "note options",
itemBuilder: _menuBuilder,
Expand Down